Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make date selector work on date ranges within the past week #1273

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented Jul 7, 2022

Contributes to #1252

Major changes:

  • Store startDate and endDate using YYYY-MM-DD format in Redux store.filters
  • Add createdDateMs to Redux store.data.requests
  • Add dateFilter to RequestsLayer to filter by createdDateMs
  • Update Redux store when ReactDayPicker picks new days for the date range

As noted in the title, the date range filtering will only work on date ranges within the past week, since we are currently only getting data from the past week. In the future, I will make another PR that gets more data if the date range is extended beyond the past week.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk requested review from funbunch and ardada2468 July 7, 2022 17:40
@nichhk nichhk linked an issue Jul 7, 2022 that may be closed by this pull request
@nichhk nichhk merged commit 16523a7 into dev Jul 11, 2022
@nichhk nichhk deleted the 1252-date-selector-not-working branch July 11, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Selector not working
1 participant